Implemented source code upload as archive instead of separate files as multipart form - #760
Merged
Conversation
Summary - Extender code coverage reportSummary
Coveragecom/defold/extender - 27.1%
com/defold/extender/builders - 0%
com/defold/extender/cache - 35.4%
com/defold/extender/cache/info - 100%
com/defold/extender/log - 0%
com/defold/extender/metrics - 7.4%
com/defold/extender/process - 10.4%
com/defold/extender/remote - 0%
com/defold/extender/services - 24%
com/defold/extender/services/cocoapods - 49%
com/defold/extender/services/data - 80.7%
com/defold/extender/tracing - 0%
|
ekharkunov
force-pushed
the
upload-sources-as-zip
branch
from
August 5, 2025 11:11
7394f4d to
611cba8
Compare
ekharkunov
force-pushed
the
upload-sources-as-zip
branch
from
August 5, 2025 11:20
611cba8 to
c2256fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now source file are collected into zip archive which uploads to the Extender as one of the field of multipart form. It's allowed to save backward compatibility on Extender's side with old client which send sources as separated field of multipart form.
New approach helps to avoid limitation on form parts amount in Jetty.
Side notes:
Fixed #590